search

linuxmint / xed

X-Apps [Text] Editor (Cross-DE, backward-compatible, GTK3, traditional UI)
GNU General Public License v2.0
454 stars 85 forks source link

Closing xed while a large file is loading does not terminate xed #637

Closed syildizz closed 4 months ago

syildizz commented 6 months ago 
 * Xed version 3.4.5
 * Distribution - Mint 21.3

Issue

When a large file is loaded a loading bar appears. If xed is closed when the loading bar is still ongoing, xed does not stop running and instead continues to use the CPU.

Steps to reproduce

  1. Click on a large file.
  2. Wait to see the loading bar at the top showing "Loading \<file> from \<folder>".
  3. Close xed before the file is able to load.
  4. Open system monitor and check CPU usage.

Expected behaviour

Xed should terminate when it is closed.

Other information

xed_loading_file

xed_still_ongoing

BanceDev commented 5 months ago

I attempted to verify this issue by opening a 512MB binary file since that is the limit of notepad on windows. I was able to close out of the editor before it finished loading. This may be potentially due to spec differences. Can anyone else verify whether this is a bottleneck of weaker hardware? If so I could look into potentially making a feature like a warning that pops up for larger files/files with long individual lines like some binary file types.

syildizz commented 5 months ago

I've added more information about this issue.

The issue still persists for me. I can close out of the editor, but the process does not terminate.

In the original comment, I used this file. I just misclicked it and closed it immediately after. That's when I first encountered this issue.

Here are my specs after running "neofetch --stdout".

OS: Linux Mint 21.3 x86_64 
Host: 82XT LOQ 15APH8 
Kernel: 6.2.0-39-generic 
Uptime: 16 mins 
Packages: 2905 (dpkg), 22 (flatpak) 
Shell: bash 5.1.16 
Resolution: 1920x1080 
DE: Cinnamon 6.0.4 
WM: Mutter (Muffin) 
WM Theme: Mint-Y-Dark-Purple (Mint-Y) 
Theme: Mint-Y-Dark-Purple [GTK2/3] 
Icons: Mint-Y-Purple [GTK2/3] 
Terminal: gnome-terminal 
CPU: AMD Ryzen 7 7840HS w/ Radeon 780M Graphics (16) @ 3.800GHz 
GPU: NVIDIA GeForce RTX 4060 Max-Q / Mobile 
GPU: AMD ATI 05:00.0 Phoenix1 
Memory: 2952MiB / 15161MiB

Here is my disk benchmark

disk_benchmark

I've attached a video where I demonstrate the issue live for better documentation.

https://github.com/linuxmint/xed/assets/118059676/c7a61baa-3f82-4faf-bd83-6522c95ca050

As can be seen, when I first click the cancel button and then close it works as expected but when I close without clicking the cancel button while the file is loading then the window closes whilst the process does not terminate.

BanceDev commented 5 months ago

I see what you mean now. When I tested I used the cancel button first before closing. I feel that is mildly intuitive but it could be a good idea to have the quit functionality just do the cancel under the hood itself and then close out. Is that essentially what you are suggesting?

syildizz commented 5 months ago

I'm suggesting that if the window closes then the program should terminate. Yes, canceling under the hood would achieve that goal. You could also not allow the window to close if the file is still loading and expect the user to press cancel first. Both options would make more sense then the program appearing to close but still running in the background in my opinion.

BanceDev commented 5 months ago

I agree. Didn't quite understand your issue at first but this certainly should get fixed. I will look into a solution here soon. Thanks for the extra information!