search

linuxmint / xreader

A generic Document Reader
GNU General Public License v2.0
216 stars 61 forks source link

Keyboard shortcuts not working on EPUB files #560

Closed spamegg1 closed 2 years ago

spamegg1 commented 2 years ago

Issue In Xreader 3.4.3, Ctrl+PageUp, Ctrl+PageDown, Shift+Ctrl+PageUp, Shift+Ctrl+PageDown, Ctrl+Home and Ctrl+End keyboard shortcuts do not work in EPUB files.

Steps To Reproduce Steps to reproduce the behavior:

  1. Open an .epub file
  2. Press Ctrl+PageDown or Ctrl+End
  3. See error: it does not move to the next/last page.

Expected behavior Shortcuts should work as expected.

Hardware and mintUpdate Is your system all up-to-date? YES

Additional context Using the Menu entries Go/Next Page, Go/Previous Page, Go/Next History Item, Go/Previous History Item, Go/First page and Go/Last page by clicking on them with the mouse cursor works.

mtwebster commented 2 years ago

I had a look at this a few days ago - this is caused by the fact that the viewing area is more or less a web page, and doesn't allow shortcuts to be handled properly when it has focus.

A workaround for now is to click into some other ui element, such as the current page box in the toolbar, or the sidebar pulldown selector, so that they receive the keyboard focus. If you do this, the shortcuts will work correctly.

spamegg1 commented 2 years ago

I understand, clicking on some other UI element works as you described. I guess EPUB renders very differently than PDF huh?

eloj commented 2 years ago

the viewing area is more or less a web page

Is this also why zoom doesn't work on epub? Whatever the reason, it's baffling.

It's a good reader, except that the second most important part (after rendering the contents correctly) doesn't work.

spamegg1 commented 2 years ago

Can confirm fixed in 3.4.4 update.