linuxmint / xreader

A generic Document Reader
GNU General Public License v2.0
211 stars 59 forks source link

Crash upon highlight and saving / replacing #613

Closed binyominzeev closed 11 months ago

binyominzeev commented 11 months ago
 * Xreader version: 3.8l.2
 * Distribution - Mint 21.2

Issue

Xreader crashes upon saving and replacing existing file.

Steps to reproduce

  1. Open the file.
  2. Highlight / annotate something.
  3. Save it to the same file, by choosing replace
  4. Xreader exits, with no error message in console, and file remains unchanged.

Expected behaviour

Save the file with the changes and leave xreader open.

Other information

The issue occurred with the following PDF file:

https://download.hebrewbooks.org/downloadhandler.ashx?req=42852

edgarogh commented 11 months ago

Same issue with completely different PDFs. No error in console (apart from the usual GTK warnings).

mtwebster commented 11 months ago

This seems to be a duplicate of #609, fixed, just needs a new version.

binyominzeev commented 10 months ago

Sorry, what is the most recent version and how can I upgrade to it? Will it be available through package?

Currently I see 3.8.2 is the most recent and this is what I have.

edgarogh commented 10 months ago

@binyominzeev Packages in Mint take time to update, you'll have to be patient, and make sure you're on the latest version of Mint in the first place

scytho commented 8 months ago

Same here. In Mint, Xreader is on 3.8.2, which is the newest version I can see here on Github.

edgarogh commented 8 months ago

Same here. In Mint, Xreader is on 3.8.2, which is the newest version I can see here on Github.

That's probably because a new release wasn't published yet. But if you compile straight from GitHub, the issue is fixed as expected.

scytho commented 7 months ago

Is this a new release? Who has to add it to the repos for Mint?