linuxmint / xreader

A generic Document Reader
GNU General Public License v2.0
211 stars 59 forks source link

xreader. Segmentation fault. #617

Closed dev0two closed 10 months ago

dev0two commented 10 months ago

Distribution

deb

Package version

3.x

Frequency

Always

Bug description

Hello!

In file shell/ev-message-area.c line 173 atk_object_set_name (atk_obj, item.label);

if item is not initialize - program break with "Segmentation fault"

I think will be good if item check before run atk_object_set_name

Now `if (icon_name) {

GtkStockItem item;

gtk_stock_lookup (icon_name, &item);

atk_object_set_name (atk_obj, item.label);

} `

It can be like `if (icon_name) {

GtkStockItem item;

gboolean item_ini = FALSE;

item_ini = gtk_stock_lookup (icon_name, &item);

if ( item_ini )

atk_object_set_name (atk_obj, item.label);

} `

After it program work fine with out "Segmentation fault"

Thank you!

Steps to reproduce

run program and try open F1 "help"

Expected behavior

I think program must work with out Segmentation fault

Additional information

No response