clefebvre
commented
8 years ago Hi @vgstef, thanks for this PR. However, I don't think it's the right thing to accept it.
If it is decided that renaming files from the app they're opened with is a valid use case, we should seek a global solution and introduce File -> Rename, alongside the already present New, Open and Save actions, not only in the viewer, but in many apps across the desktop.
I don't think it's worth seeking personally.
If you want to continue maintaining this plugin on its own, here's my quick review in case it helps:
- It would be more suitable in the File menu, rather than the Tools menu.
- The string for 'Enter the new name' is not localized.
- If you think this should be added to other apps as well, then I would suggest to externalize the dialog widget into a library (typically for xapps that would go in libxapp, I don't think that's a valid use case though, as I mentioned earlier).
Sorry it took me a while to reply, I thought about it quite a lot. It's not easy to refuse work/help, especially when it's a plugin like that. I think it makes things more inconsistent though and doesn't really add usefulness to the overall desktop experience.
Little plugin to allow the renaming of a file while viewing it.
I based it on other plugins for Xviewer in Linux Mint Mate 18.
Files extensions and translations in the plugin description are differently managed in the repo vs locally. There might be some changes to be done in that aspect. I couldn't find any description of Xviewer pluging writing conventions.