Fit to width and height

linuxmint / xviewer

A generic Image viewer

GNU General Public License v2.0

75 stars 37 forks source link

Fit to width and height #155

Closed programmer-ceds closed 2 years ago

programmer-ceds commented 2 years ago

Add menu and short-cut commands to fit to height or width. For further details see PR #143 - which was closed due to difficulties resubmitting a PR that was started with HTTPS now that SSH is mandatory.

@clefebvre - see what you think regarding centring the scrolling if the menu keys are used - this submitted version uses the mouse position even when the menu is used.

clefebvre commented 2 years ago

The symbolic icons aren't symbolic. They appear as mono (gray) instead of changing based on the background color.

I think it might be because you're shipping png versions here.

clefebvre commented 2 years ago

ok confirmed, if I remove the pngs, the symbolics work well.

clefebvre commented 2 years ago

You mixed up some code in this PR. For instance you're going back to BILINEAR..
That webp change looks like it belongs in a different PR
The PNG files need to be removed

clefebvre commented 2 years ago

I'll mark this as Next for inclusion in Mint 21.

I'm worried it might delay 20.3, especially since it requires new translations.

programmer-ceds commented 2 years ago

@clefebvre - sorry about that - I forgot the step of comparing and merging my edited files with the latest versions downloaded (which as I created a new fork of course included all of the other changes that I was then unintentionally reverting!)

I have removed the png icons and uploaded the original copies of the Makefile.am files for the icon sizes for which I deleted the png files.

Hopefully all should now be right.

clefebvre commented 2 years ago

Quick review looks good, thanks @programmer-ceds.