search

linuxmuster / linuxmuster-linbo-gui

New linbo gui based on Qt6
GNU Affero General Public License v3.0
6 stars 2 forks source link

Linbo-Gui HDD Anzeige funktioniert nicht bei NVME-SSDs #95

Open nomisge opened 2 months ago

nomisge commented 2 months ago

Bei unseren Geräten mit NVME-SSDs zeigt linbo unten links bei HDD nicht den Speicherplatz der Betriebssystempartition an. Statt dessen steht dort "HDD: Prints partition size.Usage:linbo_". Da kommt wohl noch was, das ist aber nicht mehr lesbar.

Der Fehler wurde wohl schon von anderen früher bemerkt, aber vermutlich nicht weiter beachtet: https://ask.linuxmuster.net/t/lmn-7-2-testing/9732/480

HappyBasher commented 1 month ago

Ok, it's a bug, nvme clients are affected.

HappyBasher commented 1 month ago

linbo_gui invokes linbo_cmd size /dev/nvmenp. Obviously it does not recognize the nvme disk correctly. So it's an issue of linbo_gui.

dorianim commented 1 month ago

@HappyBasher I think, disk detection should not be handled by the gui.

Would it be possible for linbo_cmd size (without further arguments) to print the size of the correct disk?

HappyBasher commented 1 month ago

linbo_cmd size awaits a parameter, either a disk (eg. /dev/nvme0n1) or a partition (eg. /dev/nvme0n1p3). The gui invokes linbo_cmd size two times, once to get the disk size and once to get cache partition data. The first invokation fails because the disk device parameter is wrong, the second is successful because in this case the partition parameter is correct. Therefore I assume the gui should be able to get the correct disk device.

HappyBasher commented 1 month ago

On the other hand, sure I may implement a linbo_size command, which gets the disk & cache device data itself. In this case the gui may invoke linbo_size_disk and linbo_size_cache. The problem is, which disk should be used if the client owns more than one? The disk where the cache partition resides? What do you think?

dorianim commented 1 month ago

The problem is, which disk should be used if the client owns more than one? The disk where the cache partition resides? What do you think?

Using the disk which contains the cache partition seems like a sensible approach.

HappyBasher commented 1 month ago

https://github.com/linuxmuster/linuxmuster-linbo7/issues/121

HappyBasher commented 1 month ago

With Linbo 4.3.0 you can use linbo_size_cache and linbo_size_disk.