search

linuxmuster / linuxmuster-linbo

Linbo imaging system for linuxmuster.net
23 stars 22 forks source link

Linbo manipulates start.conf ? #163

Closed dorianim closed 3 years ago

dorianim commented 3 years ago

There seems to be some wired issue with Linbo that occurs when a partition layout is present on the drive that does not match the partitions described in the start.conf: On the client drive I have the following partitions:

  1. /dev/sda1 windows ntfs
  2. /dev/sda2 cache

In our start.conf on the server I have:

  1. /dev/sda1 windows ntfs
  2. /dev/sda2 ubuntu ext4
  3. /dev/sda3 cache ext4

But when Linbo is booted and I do cat /start.conf this is what I get:

  1. /dev/sda1 windows ntfs
  2. /dev/sda2 ubuntu ext4
  3. /dev/sda2 cache ext4

I could only reproduce this problem with the latest stable packages: linuxmuster-linbo7 (2.3.68-0) linuxmuster-linbo-common7 (2.3.68-0)

Any ideas what could cause this?

NOTE: I was able to reproduce this thanks to this comment: https://ask.linuxmuster.net/t/labelproblem-in-linbo/6681/5

dorianim commented 3 years ago

Looks like it happens here: https://github.com/linuxmuster/linuxmuster-linbo/blob/d5576d6f58d98804cb1b208725525ba802a723e6/linbofs/init.sh#L200

This is the function that actually modifies the start.conf: https://github.com/linuxmuster/linuxmuster-linbo/blob/d5576d6f58d98804cb1b208725525ba802a723e6/linbofs/usr/bin/linbo_cmd#L468

Why does it do that? In my opinion Linbo should not touch the start.conf at all, as that makes it impossible to set a client up correctly in some cases.

HappyBasher commented 3 years ago

This was introduced in 2.3.29 in conjunction with #78, but I don't know the details anymore, that was over three years ago. I'll throw this out, no problem.

dorianim commented 3 years ago

To be honest, I don't really understand what happened back then, but if you just remove it, will it reintroduce the problems?

HappyBasher commented 3 years ago

We will see. As far as I remember now it has to do with offline mode if the cached start.conf does not match the actual partition labelling.

HappyBasher commented 3 years ago

Works without issue on my multi os efi test client. Changed the partition scheme in start.conf and re-partitioned it with linbo. Not tested: offline mode, bios client.