search

linuxmuster / linuxmuster-linbo

Linbo imaging system for linuxmuster.net
23 stars 22 forks source link

Sync fails with some cloops #190

Closed helge42 closed 3 years ago

helge42 commented 3 years ago

Today we couldn't sync one of our cloop files with the newest linbo.

I have pointed out an error in linbo_cmd. My pull request works for me and there was obviously a mistake.

I think there are more, because our cloop is identified as ntfs which it is not.

HappyBasher commented 3 years ago

AFAIK this affects a former PR from @PLanB2008.

helge42 commented 3 years ago

My pull request wasn't the cause. The cause is that the determination of fstype in the function fstype() is to simple. With my cloop-file

dd if=/dev/cloop bs=128k count=2

contains the strings: ntfs.mod ntfscomp.mod ntfs.mod ntfscomp.mod ntfs.mod ntfscomp.mod

Therefor the function fstype() yields ntfs. Since it is actually an ext4 cloop the mount with mountpart() fails.

You can revert my pull request. I am working on another solution: ntfslabel -n /dev/cloop && echo "ntfs" this is another test to check if it is an ntfs filesystem in the cloop.

HappyBasher commented 3 years ago

You are right. There are better methods to get the filesystem type. I'll fix this.

helge42 commented 3 years ago

I will post tomorrow my (partial ) fix. The problem is that fdisk can not work on /dev/cloop and you can not use fdisk for this.

Is it possible to use fstype_startconf() for this and skip the function fstype()?
if an administrator has placed a wrong cloop linbocmd will then fail. But an administrator should not do this 😉 .

HappyBasher commented 3 years ago

blkid does the trick.