search

linuxmuster / linuxmuster-linuxclient7

The new approach on connecting linuxclients to the Linuxmuster.net v7 Active Directory server.
3 stars 5 forks source link

Allow to disable drive letter on home drive #33

Open dorianim opened 3 years ago

dorianim commented 3 years ago

Allow to disable drive letter on home drive. This should be done in a config file, and is therefore blocked by #32 This also raises the question if there should also be an option to disable the drive letters in general, also for GPO-mounted drives. (overriding the option in Drives.xml)

kiarn commented 3 years ago

Hello Dorian,

Only disable H: in the config file and using useLetter for the other shares is in my opinion not good idea : I think it's easier for the admins to configure all shares in only one file.

By the other hand, if all configuration is done on the linuxclient, it will not be possible to handle this with the Webui.

Arnaud

dorianim commented 3 years ago

Hi Arnaud,

Yes, that's a problem. I think it would be fine to provide an option like disableDriveLetterUsage which just disables the use of drive letters all together and not just for H. Do you think this would be fine for now?

The only clean way for disabling handling only the H letter would be to use some AD attribute, in my opinion. But this would have to be implemented in sophomorix...

sedding commented 2 years ago

Hej,

"plus one" for the option that turns off all drive letters at one go.

In Linux-environments the windows drive letters are irrelevant and even if one would like to have them, he would like have all of them... IMHO a option that turns off drive letter usage is completely sufficient - all or none - not at least for consistency reasons.

dorianim commented 2 years ago

Yes, I agree. But as I already mentioned, #32 has to be resolved first.

jolly-jump commented 2 years ago

Can you point me to where (H:) is hardcoded? I can't find it in the source of this repo. Maybe I just don't know my regexp. :shrug: ? Thanks

dorianim commented 2 years ago

https://github.com/linuxmuster/linuxmuster-linuxclient7/blob/a6115cfec0ea7fbfae13ec36f3e27b87c09934c9/usr/lib/python3/dist-packages/linuxmusterLinuxclient7/user.py#L151

H is not actually hardcoded. It is and ldap attribute.

jolly-jump commented 2 years ago

thanks. Yes, makes sense. I changed that line for me to as a workaround

shareName = f"Home_auf_Server von {usernameString}"