Timeout lpadmin command issue#41

linuxmuster / linuxmuster-linuxclient7

The new approach on connecting linuxclients to the Linuxmuster.net v7 Active Directory server.

3 stars 5 forks source link

Timeout lpadmin command issue#41 #42

Closed martin-res closed 2 years ago

martin-res commented 2 years ago

Timeout ist auf 3 Sekunden gesetzt, kann ggf. geändert werden bei timeout erhält man returncode 124 timeout-check für "lpstat" m.E. nicht notwendig closes #41

dorianim commented 2 years ago

Also, please add coreutils to the package dependencoes to make sure, the timeout command is available 🙂

martin-res commented 2 years ago

Habe auch logging-Messages noch angepasst - muss ich nun einen neuen PR starten?

dorianim commented 2 years ago

You don't need a new PR. I will merge this one as soon as all conversations are resolved, and I'm happy with the code. :slightly_smiling_face:

By the way: You can directly commit proposed changes:

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 9a454bb7 and detected 0 issues on this pull request.

View more on Code Climate.