Allow to create cron task which can be accessed by all admins

linuxmuster / linuxmuster-webui7

Next generation web interface for linuxmuster.net v7.

https://www.linuxmuster.net

GNU General Public License v3.0

12 stars 8 forks source link

Allow to create cron task which can be accessed by all admins #210

Closed dorianim closed 2 years ago

dorianim commented 2 years ago

Hi,

I really like the new cron plugin, I'm using it to execute regular syncs with linbo_remote. But because the plugin uses my own crontab, other admins cannot see and edit my tasks. Would it be possible to add an option to create a "global" cron task (maybe in root context) which every admin can edit?

Regards Dorian

kiarn commented 2 years ago

Hi,

I was awaiting this request. I see 2 solutions for this :

as admin, open a crontab as root, which can be shared over all admins, and can reuse the same backend
edit /etc/crontab which is considered as bad practice ( what I always do ) and need some improvement on the backend.

The first solution seems better.

dorianim commented 2 years ago

I also prefer the first solution :+1:

PLanB2008 commented 2 years ago

You could also add a checkbox like dorian suggested "global-crontab" and run crontab -u global-admin or something like that (specifying the user which is linked to the global cronjobs). But this begs the question: Do we need user specified crontabs at all? I mean in a multischool environment it makes sense to have "global" cronjobs and school specific. Other than that I would not offer every user the option to run cronjobs for security reasons. What do you guys think?

kiarn commented 2 years ago

The plugin is initially a copy of the ajenti plugin, with holiday addon, which currently does not work. The actual permissions only allows global and school admins to change this, no one else. I also think that only one cron would be enough in a single school env. One more thing to discuss in a meeting ... we already have a lot for the next meeting, the biggest question will be to find a date for this.

kiarn commented 2 years ago

Hello,

Since I was working on it today to enable school specific holidays, I suggest the following :

all global admins open the same cron file, the one from the user global-admin
school admins can all open the same cron file from the school they belong. It's easy to check the school, but we need a common user for all school admins from the same school and for this point I have no idea. Other solution : only global-admins can edit cronjobs.

Arnaud

dorianim commented 2 years ago

Sounds good to me :)

kiarn commented 2 years ago

Hello,

Do you mean that only global-admins can edit cron jobs ?

Arnaud

dorianim commented 2 years ago

Yes. In my opinion, this is fine, as it is a very low-level administrative task.