import errors not properly catched

linuxmuster / linuxmuster-webui7

Next generation web interface for linuxmuster.net v7.

https://www.linuxmuster.net

GNU General Public License v3.0

12 stars 8 forks source link

import errors not properly catched #244

Open thoschi opened 2 years ago

thoschi commented 2 years ago

some errors during import of new users could be more informative. so far I encountered:

too short passwords (maybe this should even be catched in school settings - it should not be possible to choose a smaller password length than samba allows)
duplicate IDs
missing birthdate of user(s)

the process just stops with an generic python error - it would be better probably to get a proper warning what is wrong with the import data.

kiarn commented 2 years ago

Hello @thoschi,

If I understand correctly, you have imported directly a csv import, and not just added an user in the interface, right ? I must see if the above errors appear in the sophomorix command, that's the only way I can solve it.

Arnaud

kiarn commented 2 years ago

Hello @thoschi,

Since I do not use ID and wish PW, I had to test it and I call tell the following :

in the sophomorix documentation it's mentioned that the wish PW are only used for teachers ( am i wrong ? ), so I only test it with teachers. In this case, I was not able to reproduce a problem : in the listmanagement, uploading a CSV with shorts PW, then check in the Webui was not a problem. The shorts PW were replaced through sophomorix.
IDs are used with students, and I was able to reproduce the error, and to fix it ( see commit above )
missing birthdate : the Webui should test it when you try to check and do not go further. I was not able to understand what you mean. In this case, I need more details.

Arnaud

thoschi commented 2 years ago

Hello @kiarn

this issue was only about the error messages I got.

When I was importing a CSV (exported from Hera) there was a single birth date missing in one line. It would have been informative to get this information. Instead a generic Python error was thrown.

So I just wanted to suggest to inform about such issues like: "missing data in csv (user xyz)" or such.

Best regards Thomas

kiarn commented 2 years ago

Hello @thoschi

When I was importing a CSV (exported from Hera) there was a single birth date missing in one line. It would have been informative to get this information. Instead a generic Python error was thrown.

If you upload a custom CSV, there's no automatic check from sophomorix, you have to click on Save and check to achieve this. But if a birthdate is missing, the Webui will show it :

20221004-162126

Or you made it another way, and I need to know how you get the error, and which error. If I cannot reproduce the error, I cannot fix it.

Arnaud