linuxscout / pyarabic

pyarabic
GNU General Public License v3.0
450 stars 85 forks source link

Normalized Number words #33

Closed mAboshokor closed 4 years ago

mAboshokor commented 5 years ago

fixes #32 most of the number words found in Arabic text is usually normalized as Arabic speakers use words like "الف" instead of "ألف" and since the modulo already includes various normalization methods it is saner to use the normalized version of the word instead of the original form

linuxscout commented 5 years ago

I think it should be programmed differently. It means, keep correct words forms, allow automated normalized forms, and add a parameter with a default value to keep correctness. In other hand, How can vocalized an in correct word like : ثَلَاثُمِئَهِ.

mAboshokor commented 5 years ago

Hi sir @linuxscout and sorry for the late response. under the new scheme there are no problems with the compatibility of old codes. and if one needs to normalize the constants he/she will need to explicitly call this as follows:

from pyarabic import number_const
number_const.normalize_constants()

this will globally modify the values of the constants throughout the program life. the same principle can also be applied to other constants files in the repo