[ ] I have read the contributing guideline and understand that I have made the correct modifications
^ This file doesn't exist. - Also, there is no readme-vars.yml, so I made my changes directly in the README
Description:
This fixes the deprecated sync (#8) and adds an option to disable the watch command (#9).
Benefits of this PR and context:
Even though the watch command is the main goal of this repo, there is now an option to opt-out (#9).
Also, the deprecated command is migrated (#8).
How Has This Been Tested?
Tested directly
Tested it with directly modifying the container and killing the original service:
(Screenshot taken at 10:32, for timestamp references.)
Tested with own image
Tested before with image rala72/plextraktsync-test(on the screenshot, the sleep infinity is missing):
if I run it manually it works, but I don't really get the two logs above - seems like a normal dockerfile build is building the image in a different way or so?
also, the first line is from a different folder which I haven't touched; not sure about the second line
and I haven't found my echo in the container startup protocol 🤔
Conclusion
both test show the expected log line, if I create a NO_WATCH file
are these tests sufficient?
otherwise, does someone have an idea why simply running the docker file results in this bash error or how to fix it?
^ This file doesn't exist. - Also, there is no
readme-vars.yml, so I made my changes directly in the READMEDescription:
This fixes the deprecated
sync(#8) and adds an option to disable thewatchcommand (#9).Benefits of this PR and context:
Even though the
watchcommand is the main goal of this repo, there is now an option to opt-out (#9). Also, the deprecated command is migrated (#8).How Has This Been Tested?
Tested directly
Tested it with directly modifying the container and killing the original service:
(Screenshot taken at 10:32, for timestamp references.)
Tested with own image
Tested before with image
rala72/plextraktsync-test(on the screenshot, thesleep infinity is missing):Conclusion
both test show the expected log line, if I create a
NO_WATCHfileare these tests sufficient? otherwise, does someone have an idea why simply running the docker file results in this bash error or how to fix it?
Source / References:
Issues: #8, #9 https://discord.com/channels/354974912613449730/1226189951490854932/1226189951490854932