search

linuxserver / Heimdall-Apps

Apps for Heimdall
MIT License
299 stars 326 forks source link

feat: add pihole api password authentication #590

Closed imrancio closed 1 year ago

imrancio commented 1 year ago

tested on heimdall version: 2.4.13_13.0.7 and pihole version: 2022.12.1_8.0.10

pi-hole admin web UI + api can now be password protected since https://pi-hole.net/blog/2022/11/17/upcoming-changes-authentication-for-more-api-endpoints-required/#page-content.

this option is required by default in the latest TrueCharts version of pihole image image

yet the hemdall supported app for pihole had no config option for password. api would always return empty list [] when pihole password was configured. and no pihole live stats in dashboard.

this PR enables setting pihole admin password in Heimdall config image

and correctly reports empty pihole API response as invalid credentials image

api responds correctly with pihole stats when correct admin password is set image

edit: i guess this is resolved by #589? That PR uses api token hash instead of password.

imrancio commented 1 year ago

Closed because #589 is merged to master