search

linuxserver / Heimdall-Apps

Apps for Heimdall
MIT License
299 stars 326 forks source link

Request: Gitlab enhancement should offer different url for health-checks #598

Closed spenceradolph closed 5 months ago

spenceradolph commented 1 year ago

Similar to apps like proxmox or portainer, there should be an override URL to use the health check and api read.

My personal use case: The URLs I use in the top configuration are proxied with cloudflare access, so typically would have to login with my authentication provider before getting access to the application(s). This means that heimdall (currently) is unable to reach my gitlab instance through the url. But, since my heimdall is hosted in the same network as my other applications, the override url is simply the private IP and 'works'.

Possible Fix: Add a URL field (similar to proxmox / portainer since I am familiar with them) which can override the application link at the top and use this url instead for the enhacement features.

Even cooler but harder fix (and probably not needed): Add settings to give heimdall a cloudflare access token, and add those headers to all of its enhancement http requests.

spenceradolph commented 1 year ago

I was able to (partly) get around this limitation (for a different site) by starting the heimdall container with --add-host example.com:127.0.0.1.

See https://stackoverflow.com/questions/38302867/how-to-update-etc-hosts-file-in-docker-image-during-docker-build

This at least allows redirecting the domain to a specific local IP (from the POV of the container), but I'm not sure if it helps redirect to a different port.

Gitlab enhancement just in general doesn't seem to work for me. Browser Error = Cannot read properties of undefined (reading 'length')

mvdkleijn commented 9 months ago

So setting a custom URL for the API / enhancement features? Something like the Jellyfin enhanced app does sounds enough then.

Don't suppose you're up to making a PR?

LinuxServer-CI commented 7 months ago

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

LinuxServer-CI commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

LinuxServer-CI commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.