Closed imnotjames closed 6 months ago
imnotjames
commented
6 months ago I only used pass / fail here because.. there's a ton of info but super hard to tell what's interesting to others in such a small spot.
Examples:
Really anything visible in the app is pretty easy to add.
mvdkleijn
commented
6 months ago Note: I tried to add this as a requested app first but it seems the apps list on the site caps out around the "R"s so I can't actually select scrutiny to request enhanced.
That's peculiar. I'll try to check that but my access to the main repo is nil and to the site is limited.
I assume that you tested this locally?
mvdkleijn
commented
6 months ago I can unfortunately confirm that something is wrong with the site. I'll have to ask @KodeStar to take a look since he knows more about it and can deploy any possible fixes.
If he doesn't read this, I'll bump him on Discord.
imnotjames
commented
6 months ago Note: I tried to add this as a requested app first but it seems the apps list on the site caps out around the "R"s so I can't actually select scrutiny to request enhanced.
That's peculiar. I'll try to check that but my access to the main repo is nil and to the site is limited.
I assume that you tested this locally?
While the site is dinked up, Heimdall itself pulls from the gh-pages without this issue I think.
imnotjames
commented
6 months ago I'll fix the linting issues shortly. Tabs to spaces, easy peasy.
imnotjames
commented
6 months ago The failures in this lint run are now unrelated to this PR. I can fix them in a separate PR if it'd be helpful? (Some mail php file?)
imnotjames
commented
6 months ago Note: I tried to add this as a requested app first but it seems the apps list on the site caps out around the "R"s so I can't actually select scrutiny to request enhanced.
That's peculiar. I'll try to check that but my access to the main repo is nil and to the site is limited.
I assume that you tested this locally?
Yes, I'm running it locally
mvdkleijn
commented
6 months ago The failures in this lint run are now unrelated to this PR. I can fix them in a separate PR if it'd be helpful? (Some mail php file?)
You're welcome to do so, I simply didn't get around to it since I'm trying to finish off a large contribution to another project.
enhances the scrutiny app to include the passed & failed drives
I really think that this should be a bit more.. LOUD when there's failed drives but, eh..
If there's more interesting information this should have instead it can be easily pulled.
Note: I tried to add this as a requested app first but it seems the apps list on the site caps out around the "R"s so I can't actually select scrutiny to request enhanced.