search

linuxserver / Heimdall-Apps

Apps for Heimdall
MIT License
298 stars 321 forks source link

Update Immich.php #736

Closed tanmaychimurkar closed 4 months ago

tanmaychimurkar commented 4 months ago

The current implementation of Immich.php issues an invalid credentials error on Heimdall when the config is enabled with the admin API key.

The below changes fixes these issues and renders the Photos and Videos as per the api endpoint.

tanmaychimurkar commented 4 months ago

Hi @mvdkleijn, yes the changes are only minor cosmetics, just wanted to bring them inline with the style of all other SupportedApps in Heimdall dashboard.

Weird that I was getting Invalid API credentials error before the refactoring, but now it seems to be working without issues with these changes.

mvdkleijn commented 4 months ago

@tanmaychimurkar understood. please correct the linter issues found by the checks, then its good to merge as far as I'm concerned

tanmaychimurkar commented 4 months ago

@mvdkleijn oh my bad, didn't lint before. Should be good now