search

linuxserver / Heimdall-Apps

Apps for Heimdall
MIT License
298 stars 321 forks source link

added dizquetv #749

Closed HWienhold closed 3 months ago

mvdkleijn commented 3 months ago

Thanks for the contribution. There was a single PHPCS error during the checks. Please correct that issue, otherwise all looking good.

HWienhold commented 3 months ago

so ideally Pascal case = class name = namespace = name = the way the app name is actually written ? not sure how that works

mvdkleijn commented 3 months ago

See one of the other apps (for example adguardhome) in this repo as an example.

HWienhold commented 3 months ago

Didnt you mean something like phpMyAdmin? bc AdGuard Home is Pascal case. So: shall ich revert to the first commit and add: // phpcs:ignore then?

mvdkleijn commented 3 months ago

The app's directory name, classname, etc should all be PascalCase, like for AdguardHome.

But since you closed this PR, the question is no longer relevant.