search

linuxserver / Heimdall-Apps

Apps for Heimdall
MIT License
301 stars 324 forks source link

[BUG] - ArchiSteamFarm fails to authenticate #773

Closed JoshuaVandaele closed 4 weeks ago

JoshuaVandaele commented 2 months ago

Describe the bug My password contains special characters such as *, !, ^, @, %, ..., which the current implementation makes ArchiSteamFarm return 401.

To Reproduce Steps to reproduce the behavior:

  1. Go add a config for ArchiSteamFarm with the correct URL and password, which contains special characters
  2. Click on "Test"
  3. See error

Expected behavior A successfully established connection

Version info (please complete the following information):

Additional context This is fixable by using the Authentication header instead of putting the password in the URL, this issue already happened to me in the past.

LinuxServer-CI commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

JoshuaVandaele commented 1 month ago

This is still an issue

PedroBuffon commented 1 month ago

ArchiSteamFarm on $this->config->password doesn't urlencode the password so it passes like p@ssword with the special character on the url itself, which is a big problem, i've never used ArchiSteamFarm, i can make a quick fix adding a urlencode($this->config->password) to the code parts.

PedroBuffon commented 1 month ago

PR made, now just wait for the merge and test it out.