Add BABYBUDDY_REPO arg for creating docker images of forks

lutzky commented 3 years ago

[x] I have read the contributing guideline and understand that I have made the correct modifications

Description:

This change allows, when building or testing locally, to use a fork of the original repository. This is done by giving docker build the argument --build-arg BABYBUDDY_REPO=yourusername/babybuddy.

Benefits of this PR and context:

When working on babybuddy (in a forked repository), some changes would properly be tested in a docker container - ideally built the same way as the production one - before sending the pull request to https://github.com/babybuddy/babybuddy. This allows developers to do this.

How Has This Been Tested?

I have run the docker build command with --build-arg BABYBUDDY_REPO=lutzky/babybuddy --build-arg BABYBUDDY_VERSION=v1.8.0-beta. The generate container runs fine and includes the latest changes from https://github.com/babybuddy/babybuddy.

Source / References:

Asked here first: https://discord.com/channels/354974912613449730/506828136869265408/864251741208576010

LinuxServer-CI commented 3 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/babybuddy/v1.7.0-pkg-31b5b72f-pr-4/index.html https://ci-tests.linuxserver.io/lspipepr/babybuddy/v1.7.0-pkg-31b5b72f-pr-4/shellcheck-result.xml

drizuid commented 3 years ago

hard pass from me

aptalca commented 3 years ago

Thanks, but this has no benefit to us. And I don't think it has much benefit to you either.

This is only a build time change
It builds off of published stable releases.
It's easy enough for you to modify the dockerfile

What I recommend is, edit the Dockerfile and switch it to a simple git clone master/main (or custom branch) for your fork instead of a tarball download. Then you don't need to deal with publishing releases and such, and it will build the latest commit to your branch.

lutzky commented 3 years ago

Understood, thank you!

linuxserver / docker-babybuddy