don't overwrite autostart, remove duplicated code

linuxserver / docker-baseimage-kasmvnc

Base Images for remote web based Linux desktops using KasmVNC for many popular distros.

GNU General Public License v3.0

297 stars 52 forks source link

don't overwrite autostart, remove duplicated code #22

Closed spasche closed 10 months ago

spasche commented 11 months ago

[x] I have read the contributing guideline and understand that I have made the correct modifications

Description:

kasminit script should preserve existing autostart file, like it does for menu.xml

Benefits of this PR and context:

let the user customize the autostart file and have it preserved inside of the volume on restart

How Has This Been Tested?

tested locally by overriding the kasminit and run scripts

Source / References:

LinuxServer-CI commented 11 months ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/kasmvnc-base/alpine318-c0b9f9db-pkg-c0b9f9db-dev-190b72f1a9fb26151dd6ddcb06e1dd1cf8863d22-pr-22/index.html https://ci-tests.linuxserver.io/lspipepr/kasmvnc-base/alpine318-c0b9f9db-pkg-c0b9f9db-dev-190b72f1a9fb26151dd6ddcb06e1dd1cf8863d22-pr-22/shellcheck-result.xml	Tag	Passed
amd64-alpine318-c0b9f9db-pkg-c0b9f9db-dev-190b72f1a9fb26151dd6ddcb06e1dd1cf8863d22-pr-22	✅
arm64v8-alpine318-c0b9f9db-pkg-c0b9f9db-dev-190b72f1a9fb26151dd6ddcb06e1dd1cf8863d22-pr-22	✅

goldcome commented 10 months ago

When fix this issue

thelamer commented 10 months ago

@spasche I needed to touch these files for an unrelated fix and worked this logic into PRs for all flavors. Thank you for opening this and bringing it to our attention.