[FEAT] Add key bindings for window decoration

linuxserver / docker-baseimage-kasmvnc

Base Images for remote web based Linux desktops using KasmVNC for many popular distros.

GNU General Public License v3.0

281 stars 48 forks source link

[FEAT] Add key bindings for window decoration #45

Closed stevenwfoley closed 5 months ago

stevenwfoley commented 6 months ago

Is this a new feature request?

[X] I have searched the existing issues

Wanted change

Add the below described Decoration related key bindings to the section of the /etc/xdg/openbox/rc.xml file: http://openbox.org/wiki/Help:Actions#ToggleDecorations

I'm mainly interested in the ToggleDecoration, but the other two would be nice for completeness. I tested adding the entry to my local rc.xml file and it functions as expected.

Reason for change

Provide a quick method to remove and restore window decoration.

Proposed code change

github-actions[bot] commented 5 months ago

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

thelamer commented 5 months ago

Just so you know there is an env var for disabling decoration with -e NO_DECOR=true, but having a keyboard shortcut for this is not a bad idea by default in the base images.

stevenwfoley commented 5 months ago

Thanks, I did find that variable, but the issue I ran into immediatly was a popup dialog in an app (firefox) went full screen, with no way to undecorate, so I was stuck. The hotkey would solve this.

thelamer commented 5 months ago

This has been added to the baseimages it will take time to waterfall to everything downstream.