search

linuxserver / docker-baseimage-kasmvnc

Base Images for remote web based Linux desktops using KasmVNC for many popular distros.
GNU General Public License v3.0
282 stars 48 forks source link

[FEAT] File drag and drop support #67

Closed Pastitas closed 2 days ago

Pastitas commented 3 months ago

Is this a new feature request?

Wanted change

Add an togglable option to make the app upload automatically any files that are dragged and dropped there in the main page (maybe using some default upload folder setting) .

If this could somehow be integrated with the vnc host to drag the same file to the used application inside would be amazing but that seems way more complex, maybe that could be a future improvement

Reason for change

Right now there's no action associated with dragging and dropping files on kasmvnc webpage, instead the default action by the browser is done. Also in the settings menu there's an option for file upload that, when that specific window is open, allows for file uploads via drag and drop.

This makes sense for applications in which you'd normally want to drag and drop a file into, like https://github.com/linuxserver/docker-orcaslicer

Proposed code change

No response

github-actions[bot] commented 3 months ago

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

j0nnymoe commented 3 months ago

You would need to send this feature request to Kasm.

Pastitas commented 3 months ago

Opened an issue and was told that the kasmvnc is not the component that does this, so I assumed it was on your side https://github.com/kasmtech/KasmVNC/issues/250 Where can I open this then if its not there nor here? It's unclear to me where the feature I'm currently using for uploads comes from

j0nnymoe commented 3 months ago

Our baseimage consumes this repo: https://github.com/kasmtech/noVNC/ .

I'll tag in @thelamer as he'll have more knowledge on all this. Side note to what you're wanting to do, I would suggest mounting an additional volume which you keep your 3d print files in. Personally I have /models mounted which is shared with a few other things.

Pastitas commented 3 months ago

Thanks, I've created an issue there and closed the other one, this might be closed then aswell when they confirm it's their feature https://github.com/kasmtech/noVNC/issues/109

thelamer commented 3 months ago

The KasmVNC protocol does not have any file functionality that is something we bolt on with Kclient. Draggable overlay divs generally can block other specific interaction with the page depending on the browser (keyboard or mouse input) which is why it is scoped to the file browser modal.

LinuxServer-CI commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.