search

linuxserver / docker-booksonic-air

GNU General Public License v3.0
33 stars 8 forks source link

Use Ubuntu focal image for armhf only #14

Closed srd424 closed 1 year ago

srd424 commented 2 years ago

linuxserver.io

Description:

Use Ubuntu focal image for armhf only, as alpine's JRE package for armhf disables Hotspot JVM for some reason, and this causes major performance problems - e.g. 15 minute start-up times on an RPi 3B. Closes linuxserver#11.

Benefits of this PR and context:

Fixes #11 - without this, start-up times on an RPi 3B are ~15 minutes, which I feel is pretty much unusable!

How Has This Been Tested?

I have manually pushed this to my RPi 3B and it solves the startup speed problem. I have not tested the behaviour of the application extensively, but as a Java app it should be reasonably insulated from the host OS. Also, the existing state of the app on armhf is arguably unusable anyway, so little to lose by merging this, particularly as armhf is, I understand, now deprecated.

Source / References:

https://git.alpinelinux.org/aports/commit/community/openjdk8?id=2ef23635a7f6cbdb54c363a3970362879e28e7f4

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/booksonic-air/v2201.1.0-pkg-35509b26-pr-14/index.html https://ci-tests.linuxserver.io/lspipepr/booksonic-air/v2201.1.0-pkg-35509b26-pr-14/shellcheck-result.xml

github-actions[bot] commented 2 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

drizuid commented 1 year ago

We no longer support arm32, I believe that will negate the need for this PR, can you confirm?

srd424 commented 1 year ago

I think so, yes - it's been ages since I looked at this and can't remember the details. AFAICR I've migrated my own stuff either to arm64 or away from booksonic entirely anyway. I will close.