search

linuxserver / docker-booksonic-air

GNU General Public License v3.0
32 stars 8 forks source link

Document JAVA_OPTS in readme #4

Closed chessmango closed 2 years ago

chessmango commented 3 years ago

linuxserver.io

Desired Behavior

JAVA_OPTS should be documented, as it is with linuxserver/docker-airsonic

Current Behavior

JAVAOPTS applies here, but is not documented in this image's readme. In addition, it may be worthwhile documenting usage of 'server.use-forward-headers=true' as an option when reverse proxying. I've seen issues in Airsonic's own repo mentioning that Nginx works as expected, but using Traefik here (albeit sending expected headers, including X-Forwarded-Proto) and had to explicitly set this parameter. ¯_(ツ)/¯

Alternatives Considered

N/A

github-actions[bot] commented 3 years ago

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

chessmango commented 3 years ago

Happy to put together a PR for this, incidentally. Just not sure how much you'd like random users contributing to your core documentation :)

Roxedus commented 3 years ago

Go ahead :), read https://github.com/linuxserver/docker-booksonic-air/blob/master/.github/CONTRIBUTING.md especially the readme part

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.