Remove db_pass escape logic

drizuid commented 1 year ago

We have had some infrequent complaints about DB_PASS not working at times. Unfortunately, the users who complain never provide any relevant detail that allows us to work to resolve the issue. The logic in this is to attempt to escape special characters in the password before feeding it into the database, the users who have the issue erroneously believe that db_password is the right var because of a lack of understanding, however, this does indicate that bypassing our escape logic is a potential solution. I did some testing with various passwords and had no issues by removing our escape logic at all.

If this works, we will want to replicate this PR to mariadb and other containers with a similar var and escape logic.

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/bookstack/v22.09.1-pkg-dc94345f-pr-140/index.html https://ci-tests.linuxserver.io/lspipepr/bookstack/v22.09.1-pkg-dc94345f-pr-140/shellcheck-result.xml

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/bookstack/v22.09.1-pkg-dc94345f-pr-140/index.html https://ci-tests.linuxserver.io/lspipepr/bookstack/v22.09.1-pkg-dc94345f-pr-140/shellcheck-result.xml

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/bookstack/v22.09.1-pkg-dc94345f-pr-140/index.html https://ci-tests.linuxserver.io/lspipepr/bookstack/v22.09.1-pkg-dc94345f-pr-140/shellcheck-result.xml

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/bookstack/v22.09.1-pkg-dc94345f-pr-140/index.html https://ci-tests.linuxserver.io/lspipepr/bookstack/v22.09.1-pkg-dc94345f-pr-140/shellcheck-result.xml

linuxserver / docker-bookstack

Remove db_pass escape logic #140