linuxserver / docker-bookstack

A Docker container for the BookStack documentation wiki
GNU General Public License v3.0
747 stars 108 forks source link

[FEAT] .0 release of each feature release doesn't have a corresponding tag. #147

Closed bendem closed 1 year ago

bendem commented 1 year ago

Is this a new feature request?

Wanted change

Versions 22.10, 22.11, etc. don't have a corresponding tag while subsequent minor versions do (22.10.1). It would be great if tags were provided so that we could follow a specific feature release (i.e. 22.10, updated with every minor release) and a 22.10.0, so we have a consistent tagging system for all version.

Reason for change

Currently, we have to use a version scheme for minor releases and another version scheme for feature releases. It's confusing and annoying to automate.

Proposed code change

I don't know how tagging is done currently so it's hard to say. Always providing the exact upstream version as a tag sounds like a good first step, the rest is sugar on top.

github-actions[bot] commented 1 year ago

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

Roxedus commented 1 year ago

22.10 doesn't conform to semver, which is the mechanism in our unified tagging strategy the 22.10.1 is born from. The code for our semver strategy is here

ssddanbrown commented 1 year ago

Just to confirm from my perspective, it looks like images are already tagged with the exact BookStack version as requested. BookStack itself omits the minor version component for initial feature releases and does not follow semver, so the linuxserver tag versions inherit that trait.

bendem commented 1 year ago

so the linuxserver tag versions inherit that trait.

It doesn't, there is no linuxserver/bookstack:22.11, that's my point. Now I can understand this is annoying, I might bring it up upstream to see how much of a hassle it would be.

ssddanbrown commented 1 year ago

I was looking at the version- tags, since it looked like these are specifically to tag against the BookStack project version and appear to be consistently applied, for example: lscr.io/linuxserver/bookstack:version-v22.11. Can observe the same tags on the docker hub image also.