Added php81-iconv as an installed php extension

ssddanbrown commented 1 year ago

[x] I have read the contributing guideline and understand that I have made the correct modifications

Description:

This adds the iconv PHP extension to the build scripts since the iconv php extension is a requirement for BookStack that has previously been poly-filled but is now needed as an extension.

See https://github.com/linuxserver/docker-bookstack/issues/162 for more detail.

Benefits of this PR and context:

This adds a required extension that's needed in certain features of BookStack, such as QR code generation for TOTP MFA.

How Has This Been Tested?

I build a fresh image for the modified files, then used that in a compose setup to check the image worked, at that the error produced from the lack of the iconv extension no longer shows. I also checked the build log to ensure the icon extension is no longer uninstalled in the build process, like it was before.

This was on an x64 Fedora Linux 37 system. I did not test the arm image(s) specifically.

Source / References:

https://github.com/linuxserver/docker-bookstack/issues/162

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/bookstack/v23.02.1-pkg-32b5a682-pr-164/index.html https://ci-tests.linuxserver.io/lspipepr/bookstack/v23.02.1-pkg-32b5a682-pr-164/shellcheck-result.xml

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/bookstack/v23.02.1-pkg-32b5a682-pr-164/index.html https://ci-tests.linuxserver.io/lspipepr/bookstack/v23.02.1-pkg-32b5a682-pr-164/shellcheck-result.xml

linuxserver / docker-bookstack