Closed cdrfun closed 1 year ago
Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.
For context, this is a new CLI I added in the BookStack may release. Details on blog here.
Supporting this tool, I also designated the <app>/storage/backups
folder as a default backup output folder, so it'd probably be good to expose this to /config
for persistence/access.
The CLI does do updates, which is a bit awkward in this context since I'd consider updating via the CLI the wrong approach, so it might be better if that specific command fails/stops early in some way. Might be an idea for me to build in some handling on the CLI side of things.
If I find a spare moment I'll look to test the CLI in the image myself and put a PR together.
Started on this on my fork/branch here. Since this requires mysqldump, this does inflate the image a tad. About 30MB, or ~10% image size increase. Can be handy to have mariadb-client available, inside this image, for additional purposes upon the CLI's usage though. There are a few bugs/quirks that ideally need to be handled on the CLI project side, which I've opened as issues to deal with:
I'll look to get those points addressed for the next BookStack patch release.
Just an update, today's BookStack patch release did make many CLI updates to get us closer for this, and I was aiming to create a PR today, but I came across some extra issues while testing the ARM64 image build. The combination of symlinks, multiple different system storage volumes/filesystems really brings out the edge-case problems in the CLI.
I could create the PR now, but I think it's better to wait so that that the CLI is erroring early as reported, rather than missing content in backups. Will be a future BookStack patch release before I come back to this for a PR (May end up being a few weeks out).
If you haven't already handled it, my suggestion would be an env we can set to tell the cli that it's running in docker and not to try and run updates.
This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.
The PR (https://github.com/linuxserver/docker-bookstack/pull/173) seems to get merged soon. I'll test the issue if when it is.
Is there an existing issue for this?
Current Behavior
When running
bookstack-system-cli backup
from command line while in/app/www
an error occurs: The "zip" PHP extension is required to run this commandExpected Behavior
The command should be able to create a backup file.
Steps To Reproduce
Environment
CPU architecture
x86-64
Docker creation
Container logs