linuxserver / docker-bookstack

A Docker container for the BookStack documentation wiki
GNU General Public License v3.0
725 stars 105 forks source link

[FEAT] Add Version Tags to docker images #204

Closed kale1d0code closed 6 months ago

kale1d0code commented 6 months ago

Is this a new feature request?

Wanted change

To add version tags to docker images so I can pin software version

Reason for change

To be able to continue receiving OS updates for the container but keep current app version

Proposed code change

change the release script so that it adds version tags to docker images as they are being published

Roxedus commented 6 months ago

The requested changes are not feasible.

ssddanbrown commented 6 months ago

Looking at the tags applied, I thought this was already done tbh. For example: lscr.io/linuxserver/bookstack:version-v23.12.1.

kale1d0code commented 6 months ago

I found out a way to view tags that could be on the linuxserver image registry. Looking into the Dockerfile, it looks at https://api.github.com/repos/bookstackapp/bookstack/releases navigating to this page and reading the JSON it is possible to find the version numbers for the bookstack images.

Using the latest version I was able to find a manifest for: lscr.io/linuxserver/bookstack:23.12.1

I've had difficulty finding the schema linuxserver uses for version tags as its not possible to view available tags on lscr.io and they are not documented anywhere

ssddanbrown commented 6 months ago

@kale1d0code I looked to the container package for this repo; provides an easier to read view: https://github.com/linuxserver/docker-bookstack/pkgs/container/bookstack

thespad commented 6 months ago

https://www.linuxserver.io/blog/docker-tags-so-many-tags-so-little-time

aptalca commented 6 months ago

Also, Docker hub allows for filtering and searching through tags, which is quite a bit nicer than ghcr.

https://hub.docker.com/r/linuxserver/bookstack/tags

However that doesn't change the fact that the following request is not feasible (as rox mentioned) To be able to continue receiving OS updates for the container but keep current app version

You can pin to an older version/tag, but that older version/tag will not receive os package updates. Only the latest/current version/tag will.