search

linuxserver / docker-bookstack

A Docker container for the BookStack documentation wiki
GNU General Public License v3.0
785 stars 108 forks source link

[BUG] Embedded media doesn't seem to work with image files w/o manual editing #233

Open kristiandg opened 3 days ago

kristiandg commented 3 days ago

Is there an existing issue for this?

Current Behavior

On this example page: https://demo.bookstackapp.com/books/bookstack-demo-site/page/video-embed-example

The sentence says "You can embed anything that can be included via an iframe..."

I pasted a link to an image file that I'm able to view by pasting directly into my browser, but when I use the Insert Media tool and paste that same image URL, it doesn't work, and ends up not embedding the image. I can do this with YouTube links without issue, but not image files.

Upon switching to the Embed tab, you can see that the source code is assuming it's a video file, as it has several video related tags (like "video poster", "controls", etc.). You have to manually edit the code to force it to be an image. However, once you do, future edits show the friendlier box for image editing.

I initially looked at the Image Select tool, but that only seems to support stored/uploaded image files, not links to off-server images. Whether the appropriate place for embedding an image file belongs in the Image Select tool or the Insert Media tool, I'll leave up to you all, but there should be a mechanism to do it that's as WYSIWYG as the function for embedding video files.

Expected Behavior

I had expected, just like a video, the image file would have also been embedded and pulled from the source location.

Steps To Reproduce

  1. Edit a page
  2. Use the Insert/Edit Media tool, and place a URL in the Source box.
  3. View the Source version of what it's planning to create
  4. Notice it assumes video with the "video poster" tag.
  5. You have to manually modify the code with an "img src" tag, to correct for the issue.

Environment

- OS:Azure Linux App Service Host
- How docker service was installed:Deploy on Azure App Services container

CPU architecture

x86-64

Docker creation

Auto deploy from Azure App Service, by providing repo URL.

Container logs

Since this isn't a docker issue, I don't believe these logs would apply.
github-actions[bot] commented 3 days ago

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.