linuxserver / docker-calibre

GNU General Public License v3.0
385 stars 65 forks source link

Web browser tab title needed #16

Closed orsomething1030 closed 3 years ago

orsomething1030 commented 5 years ago

Expected Behavior

The web browser tab should be "Calibre" or something like that so it's easily identifiable.

Current Behavior

The web brower tab is named "127.0.0.1"

Steps to Reproduce

  1. Open web browser to calibre docker ip address:port
CHBMB commented 5 years ago

I don't know how feasible this will be, as you're actually opening a web browser to a guacamole remote desktop, which then displays Calibre

orsomething1030 commented 5 years ago

The deprecated aptalca/docker-rdp-calibre container, which I assume this one is based off of, shows Calibre in the browser tab. That's only reason I noticed to be honest.

CHBMB commented 5 years ago

@aptalca Would be better placed to answer, but I think the internals are a fair bit different between the two, I could, however, be completely & utterly wrong.

stev3nw commented 5 years ago

Right way (currently unavailable)

The guacamole title on browser reflects connection name which set in /etc/guacamole/user-mapping.xml

Example:

<user-mapping>
    <authorize
            username="GUAC_USER"
            password="GUAC_PASS"
            encoding="md5">
        <!-- Add connection element for your favorite name, otherwise the title would be "DEFAULT" -->
        <connection name="Calibre">
            <protocol>rdp</protocol>
            <param name="hostname">127.0.0.1</param>
            <param name="port">3389</param>
            <param name="color-depth">16</param>
            <param name="ignore-cert">true</param>
            <param name="username">abc</param>
            <param name="password">abc</param>
        </connection>
    </authorize>
</user-mapping>

Unfortunately, this only works while connecting state. Once you get into the Calibre UI, the title would be replace with hostname (127.0.0.1) immediatly. It's a bug of Guacamole 0.9.13 - 0.9.14, see GUACAMOLE-502.

This should work at Guacamole 1.0.0 and later (not tested)

Workaround

We could manually assign a identifiable hostname to container itself by modify /etc/hosts in container (or use --volume to replace one), and then change the hostname setting in /etc/guacamole/user-mapping.xml to use it.

Note. Docker container usually has a hostname just like container name to itself by default, so editing hosts is not always necessary.

github-actions[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

aptalca commented 3 years ago

no longer relevant due to baseimage change