linuxserver / docker-calibre

GNU General Public License v3.0
339 stars 62 forks source link

fix umask #79

Closed aptalca closed 2 years ago

aptalca commented 2 years ago

closes #78

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/calibre/v5.39.1-pkg-02a38023-pr-79/index.html https://ci-tests.linuxserver.io/lspipepr/calibre/v5.39.1-pkg-02a38023-pr-79/shellcheck-result.xml

RudyBzhBzh commented 2 years ago

Hi, Trying to understand s6 and the docker images inheritance for docker-calibre.

In autostart, there is : s6-envdir -fn -- /var/run/s6/container_environment /usr/bin/calibre $CLI_ARGS

You try this (which is not working for me... don't know why...) :

s6-envdir -fn -- /var/run/s6/container_environment umask ${UMASK:-022}
s6-envdir -fn -- /var/run/s6/container_environment /usr/bin/calibre $CLI_ARGS

But what about using /usr/bin/with-contenv (the aim of it is to use env variable set with s6-envdir, correct ?)

xxxxxxxxxxxx # env | grep UMASK
UMASK=002
xxxxxxxxxxxx # umask
0022
xxxxxxxxxxxx # /usr/bin/with-contenv sh
# umask
0002

So would something like this could make sense : s6-envdir -fn -- /var/run/s6/container_environment /usr/bin/with-contenv /usr/bin/calibre $CLI_ARGS

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/calibre/v5.39.1-pkg-02a38023-pr-79/index.html https://ci-tests.linuxserver.io/lspipepr/calibre/v5.39.1-pkg-02a38023-pr-79/shellcheck-result.xml