search

linuxserver / docker-ci

Container for running basic sanity checks on containers post build and before upload
GNU General Public License v3.0
5 stars 6 forks source link

[BUG] incorrect ghcr link for lsiodev and lspipepr images #57

Closed aptalca closed 2 weeks ago

aptalca commented 3 weeks ago

Is there an existing issue for this?

Current Behavior

If the image built is a dev or pr image, the link to the image tag in the ci report is incorrect.

For instance, the amd64 pr image for jellyfin is currently linked to: https://ghcr.io/lspipepr/jellyfin:amd64-nightly-2024091605ubu2404-pkg-a1d32746-dev-9f97c8782aab3a8c6b5c3b1209ab0e2caf79c146-pr-266 but it should be https://ghcr.io/linuxserver/lspipepr-jellyfin:amd64-nightly-2024091605ubu2404-pkg-a1d32746-dev-9f97c8782aab3a8c6b5c3b1209ab0e2caf79c146-pr-266

Here's the ci results page: https://ci-tests.linuxserver.io/lspipepr/jellyfin/nightly-2024091605ubu2404-pkg-a1d32746-dev-9f97c8782aab3a8c6b5c3b1209ab0e2caf79c146-pr-266/index.html

Expected Behavior

For ghcr, the link format for pr images should be https://ghcr.io/linuxserver/lspipepr-<container-name>:<image-tag> and for dev images, it should be https://ghcr.io/linuxserver/lsiodev-<container-name>:<image-tag>

I believe the issue stemmed from converting these links over from docker hub links, where we used separate orgs for lsiodev and lspipepr whereas on ghcr, we use the same org linuxserver for everything, but we prepend the image names with either lsiodev or lspipepr

Steps To Reproduce

  1. Go to https://ci-tests.linuxserver.io/lspipepr/jellyfin/nightly-2024091605ubu2404-pkg-a1d32746-dev-9f97c8782aab3a8c6b5c3b1209ab0e2caf79c146-pr-266/index.html
  2. Click on the image tag under PASS or FAIL

Environment

N/A

Docker creation

N/A

Container logs

N/A