search

linuxserver / docker-ci

Container for running basic sanity checks on containers post build and before upload
GNU General Public License v3.0
5 stars 6 forks source link

Fix/add lsiobase #59

Closed GilbN closed 3 days ago

GilbN commented 1 week ago

Make url for baseimage

https://gilbnlsio2.s3.us-east-1.amazonaws.com/lsiobase/ubuntu/noble-566a4560-ls19/index.html

https://ci-tests.linuxserver.io/lsiobase/ubuntu/noble-566a4560-ls19/index.html

LinuxServer-CI commented 1 week ago

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-ci:e22e560b-pkg-e22e560b-dev-e221fb8f3f1af6a402ad30b26ce235dfbc126177-pr-59

aptalca commented 4 days ago

This PR looks good, but it reminded me that we should move away from passing lsiobase/alpine or lsiodev/blah as the IMAGE value to the ci container. This is something we'll have to change in the jenkins builder, but we also need to make the ci container ready for it.

We also have a draft PR: https://github.com/linuxserver/docker-jenkins-builder/pull/183 which would move everything from lsiobase, lsiodev and lspipepr orgs on docker hub to the main linuxserver org, and the image names will be consistent with the ghcr naming scheme (ie. linuxserver/baseimage-alpine, linuxserver/lsiodev-blah and linuxserver/lspipepr-blah). We prepared that PR when docker hub initiated pull limits and our ci builds were failing, but we were able to solve the issue another way. So the PR is still pending, but with a lower priority.

Just a heads up

GilbN commented 3 days ago

Yup, CI container should handle it just fine.