search

linuxserver / docker-cops

GNU General Public License v3.0
40 stars 13 forks source link

Config #57

Closed mikespub closed 2 months ago

mikespub commented 2 months ago

linuxserver.io

Description:

Add $config['cops_kepubify_path'] in root/defaults/config_local.php

Benefits of this PR and context:

Default configuration of kepubify path in line with previous Dockerfile change

How Has This Been Tested?

Create docker image and run

Source / References:

https://github.com/mikespub-org/seblucas-cops/issues/77

LinuxServer-CI commented 2 months ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/cops/2.7.5-pkg-7c7d74ba-dev-8a6b616a4240ab814174cf4e58962dc8e7402f36-pr-57/index.html https://ci-tests.linuxserver.io/lspipepr/cops/2.7.5-pkg-7c7d74ba-dev-8a6b616a4240ab814174cf4e58962dc8e7402f36-pr-57/shellcheck-result.xml Tag Passed
amd64-2.7.5-pkg-7c7d74ba-dev-8a6b616a4240ab814174cf4e58962dc8e7402f36-pr-57 ✅
arm64v8-2.7.5-pkg-7c7d74ba-dev-8a6b616a4240ab814174cf4e58962dc8e7402f36-pr-57 ✅
LinuxServer-CI commented 2 months ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/cops/2.8.1-pkg-68c4e92d-dev-9769670e6ece640db7acc6b95ed83655ebae73eb-pr-57/index.html https://ci-tests.linuxserver.io/lspipepr/cops/2.8.1-pkg-68c4e92d-dev-9769670e6ece640db7acc6b95ed83655ebae73eb-pr-57/shellcheck-result.xml Tag Passed
amd64-2.8.1-pkg-68c4e92d-dev-9769670e6ece640db7acc6b95ed83655ebae73eb-pr-57 ✅
arm64v8-2.8.1-pkg-68c4e92d-dev-9769670e6ece640db7acc6b95ed83655ebae73eb-pr-57 ✅
LinuxServer-CI commented 2 months ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/cops/3.1.1-pkg-d408948f-dev-c5bc085bc03ed6cbbd82498506fece689d569673-pr-57/index.html https://ci-tests.linuxserver.io/lspipepr/cops/3.1.1-pkg-d408948f-dev-c5bc085bc03ed6cbbd82498506fece689d569673-pr-57/shellcheck-result.xml Tag Passed
amd64-3.1.1-pkg-d408948f-dev-c5bc085bc03ed6cbbd82498506fece689d569673-pr-57 ✅
arm64v8-3.1.1-pkg-d408948f-dev-c5bc085bc03ed6cbbd82498506fece689d569673-pr-57 ✅
LinuxServer-CI commented 2 months ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/cops/3.1.1-pkg-d408948f-dev-c40c2e4db473136242fcf10544c3e72919de9957-pr-57/index.html https://ci-tests.linuxserver.io/lspipepr/cops/3.1.1-pkg-d408948f-dev-c40c2e4db473136242fcf10544c3e72919de9957-pr-57/shellcheck-result.xml Tag Passed
amd64-3.1.1-pkg-d408948f-dev-c40c2e4db473136242fcf10544c3e72919de9957-pr-57 ✅
arm64v8-3.1.1-pkg-d408948f-dev-c40c2e4db473136242fcf10544c3e72919de9957-pr-57 ✅
mikespub commented 2 months ago

Hi @aptalca & friends

I've updated this PR to include the config changes needed for COPS 3.x. Any chance this could be reviewed?

Thanks :-) P.S.: if you have some good guidelines on how to adapt the nginx default.conf.sample file to make use of a front controller and get rid of index.php/ in URLs, I'd be happy to test it for COPS and submit another PR later

aptalca commented 2 months ago

Thanks @mikespub

I did a quick review and it looks good.

But I'm also thinking we should do the migration of the config file automatically for existing users.

If you're planning on releasing v3 soon, we can temporarily pause our external checks, update this PR with the migration and after you release v3 we merge this PR and reenable external checks. Does that work?

aptalca commented 2 months ago

On second thought, we could probably do the migration conditionally so we don't have to coordinate releases

aptalca commented 2 months ago

Opened a PR https://github.com/mikespub-org/docker-cops/pull/1

LinuxServer-CI commented 2 months ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/cops/3.1.1-pkg-d408948f-dev-e7061aed628b200b22f9c3e4344eb1bff06491d1-pr-57/index.html https://ci-tests.linuxserver.io/lspipepr/cops/3.1.1-pkg-d408948f-dev-e7061aed628b200b22f9c3e4344eb1bff06491d1-pr-57/shellcheck-result.xml Tag Passed
amd64-3.1.1-pkg-d408948f-dev-e7061aed628b200b22f9c3e4344eb1bff06491d1-pr-57 ✅
arm64v8-3.1.1-pkg-d408948f-dev-e7061aed628b200b22f9c3e4344eb1bff06491d1-pr-57 ✅
mikespub commented 2 months ago

Great, that PR looks fine to me - merged :-)

I did something similar in COPS itself for non-docker installations, but this should cover the docker version too - thanks @aptalca

aptalca commented 2 months ago

I just noticed your release candidate is marked as latest in github releases so it's already building 3.1.1 And it looks like we already pushed a broken release as a result. Oops

The webpage seems to error out on a fresh container as seen in the test result above: https://ci-tests.linuxserver.io/lspipepr/cops/3.1.1-pkg-d408948f-dev-e7061aed628b200b22f9c3e4344eb1bff06491d1-pr-57/index.html

mikespub commented 2 months ago

Actually COPS is now sending you to index.php/check instead of checkconfig.php - which is the output you see there. The docker part is fine, but the COPS part is not (quite) yet.

That's why I called this a release candidate rather than a release, to iron out these little issues. Once this docker-cops PR is merged and working, I can prepare a next release with bug fixes on the COPS side and it'll automatically go through the next time. But for that I needed the config file issue resolved first :-)

mikespub commented 2 months ago

Thanks @aptalca - always a pleasure working with the linuxserver team... You do great work, and we appreciate it even if we don't say it enough :-)

aptalca commented 2 months ago

You guys are doing the actual work, we just try to keep up 😅