linuxserver / docker-daapd

GNU General Public License v3.0
110 stars 36 forks source link

Fix the Build #32

Closed BernsteinA closed 4 years ago

BernsteinA commented 4 years ago

This supersedes https://github.com/linuxserver/docker-daapd/pull/31 See also https://github.com/ejurgensen/forked-daapd/issues/871

aptalca commented 4 years ago

Build failing

checking for library containing antlr3BaseRecognizerNew...... no
configure: error: in `/tmp/source/forked-daapd':
configure: error: Function antlr3BaseRecognizerNew in libantlr3c not found.
Install ANTLR3 C runtime in the default include path, or alternatively set
library specific environment variables ANTLR3C_CFLAGS
and ANTLR3C_LIBS.
See `config.log' for more details
kinglouie commented 4 years ago

@BernsteinA I think this does not supersede #31 I only got the build working if I use this image containing the libantlr build from source https://github.com/chme/docker-daapd/tree/fixbuild.

The alpine version bump just fixes the websocket issue.

BernsteinA commented 4 years ago

@kinglouie oh shoot. I misunderstood your comment, thought that updating alpine fixed both.

teejo75 commented 4 years ago

You need to add libantlr3c as well as libantlr3c-dev to the build packages. This allowed the image to build for me.

https://github.com/linuxserver/docker-daapd/blob/57615bebc1613b6e33a64c05b5c6924907ab6e2e/Dockerfile#L45

However, now there is the issue where daapd just restarts constantly. * When you access the web interface.

kinglouie commented 4 years ago

My build based on https://github.com/chme/docker-daapd/tree/fixbuild with the additional change of the alpine version works flawlessly with high usage. Didn't crash since deployment a few weeks ago so I would suggest using that antlr3c fixed istead of using the libantlr3c-dev package.

@BernsteinA do you want to update this PR or should I open a new one?

nicx commented 4 years ago

@kinglouie do you have your build on docker hub? I would be really happy to test it ;)

LinuxServer-CI commented 4 years ago

I am a bot, here are the test results for this PR: https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/daapd/27.0-pkg-85d79f3f-pr-32/index.html https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/daapd/27.0-pkg-85d79f3f-pr-32/shellcheck-result.xml

LinuxServer-CI commented 4 years ago

I am a bot, here are the test results for this PR: https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/daapd/27.0-pkg-85d79f3f-pr-32/index.html https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/daapd/27.0-pkg-85d79f3f-pr-32/shellcheck-result.xml

BernsteinA commented 4 years ago

@thelamer I think we're back up and running

aptalca commented 4 years ago

It seems to keep crashing and restarting when I open the webpage

You can test with docker run -d --rm --name daapd --net=host lspipepr/daapd Check the logs with docker logs daapd -f and visit the url

teejo75 commented 4 years ago

The build where libantl3r is built from source works perfectly, I tested it last night updating the alpine to use 3.11 as @kinglouie said.

BernsteinA commented 4 years ago

ok yeah it's crashing / restarting for me too. I guess we have to build antlr from source after all

thelamer commented 4 years ago

Stop the blind commits you can test building images locally on x86, the instructions are in all of our readmes

LinuxServer-CI commented 4 years ago

I am a bot, here are the test results for this PR: https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/daapd/27.0-pkg-85d79f3f-pr-32/index.html https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/daapd/27.0-pkg-85d79f3f-pr-32/shellcheck-result.xml

nicx commented 4 years ago

any news to this? will it be merged?

aptalca commented 4 years ago

Is it working? Tested?

BernsteinA commented 4 years ago

I’m running it on armhf with no problems that I’ve noticed

On Sat, Feb 29, 2020 at 8:05 PM aptalca notifications@github.com wrote:

Is it working? Tested?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/linuxserver/docker-daapd/pull/32?email_source=notifications&email_token=ABDX4TVMGVV2VJ35RLFSTRDRFGYHLA5CNFSM4KE2IXXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENMNR4Q#issuecomment-593025266, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDX4TSF6UP5GS6OH5SYDV3RFGYHLANCNFSM4KE2IXXA .

aptalca commented 4 years ago

@BernsteinA thanks for all the work