New: Usr: Enabled Spotify for x86_64 and armv7

bverhagen commented 4 years ago

Description:

Installed libspotify and enabled forked-daapd build with libspotify.

Benefits of this PR and context:

Fixes #36

How Has This Been Tested?

Tested fully on x86_64
Tested partially on armv7
No changes to arm64

Source / References:

aptalca commented 4 years ago

mxml and mxml-dev are in edge community

LinuxServer-CI commented 4 years ago

I am a bot, here are the test results for this PR: https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/daapd/27.2-pkg-470f2d7d-pr-37/index.html https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/daapd/27.2-pkg-470f2d7d-pr-37/shellcheck-result.xml

LinuxServer-CI commented 4 years ago

I am a bot, here are the test results for this PR: https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/daapd/27.2-pkg-470f2d7d-pr-37/index.html https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/daapd/27.2-pkg-470f2d7d-pr-37/shellcheck-result.xml

aptalca commented 4 years ago

@bernsteinA quick review?

BernsteinA commented 4 years ago

Looks fine, I won't really be able to test this. I noticed that the Dockerfile.aarch64 does not have all the same changes as the other two dockerfiles. Is this intended? @bverhagen

bverhagen commented 4 years ago

@BernsteinA : Unfortunately: yes. I tried to give some more details in the associated issue #36 : libspotify is simply not available for arm64, nor are the sources. Some more information here and in other issues concerning this topic.

I think it would make sense that, until forked-daapd provides an alternative for libspotify, we offer Spotify to the architectures for which libspotify is available.

linuxserver / docker-daapd