Changes to build against owntone-server release

linuxserver / docker-daapd

GNU General Public License v3.0

103 stars 37 forks source link

Changes to build against owntone-server release #51

Closed dhutchison closed 2 years ago

dhutchison commented 3 years ago

[x] I have read the contributing guideline and understand that I have made the correct modifications

Description:

Changes paths in the build & links to refer to the new name of the project, owntone-server. As-is the main branch of this project does not build.

closes #50

Benefits of this PR and context:

Fixes #50.

How Has This Been Tested?

Verified that x86 image built and I could install & run the container.

Source / References:

LinuxServer-CI commented 3 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/daapd/28.1-pkg-81ce7b79-pr-51/index.html https://ci-tests.linuxserver.io/lspipepr/daapd/28.1-pkg-81ce7b79-pr-51/shellcheck-result.xml

BernsteinA commented 2 years ago

This looks good to me. Can I get a quick ok from you @aptalca before I merge?

aptalca commented 2 years ago

@BernsteinA lgtm

BernsteinA commented 2 years ago

Ok so I don't know who has write permissions to merge this now... cc @Roxedus

Roxedus commented 2 years ago

I got you

BernsteinA commented 2 years ago

I don't know where to put this, but we should add a notice somewhere that pulling the latest image will create a new settings file owntone.conf and will not read from your existing forked-daapd.conf Could be a very disruptive change for many users...

BernsteinA commented 2 years ago

Maybe we should roll back this pr, and change the docker image name before applying it again?