New: Usr: Removed librespot daemon

bverhagen commented 2 years ago

There are some inherent issues controlling librespot over the pipe with Owntone

Librespot was added as a workaround to make Spotify work on ARM platforms. However, Owntone 28.2 has added native Spotify support for all platforms.

Even though removing Librespot will eliminate Spotify connect support, the interface between Owntone and Librespot using a named pipe is far from perfect and has some corner cases that are hard to fix without any intervention (next to a difficult configuration, there is only one-way synchronization etc.). I propose therefore to remove it again from this library and wait/hope Owntone will one day support Spotify connect out of the box.

[x] I have read the contributing guideline and understand that I have made the correct modifications

Description:

Removed my earlier PR on adding Librespot, since it is no longer needed, as already mentioned here: https://github.com/linuxserver/docker-daapd/issues/38 but somehow it still got merged.

Benefits of this PR and context:

See above

How Has This Been Tested?

Tested on Aarch64. AMD64 architectures are not impacted.

Source / References:

https://github.com/owntone/owntone-server/pull/1253

bverhagen commented 2 years ago

Closes #53

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/daapd/28.2-pkg-003c8411-pr-55/index.html https://ci-tests.linuxserver.io/lspipepr/daapd/28.2-pkg-003c8411-pr-55/shellcheck-result.xml

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/daapd/28.2-pkg-003c8411-pr-55/index.html https://ci-tests.linuxserver.io/lspipepr/daapd/28.2-pkg-003c8411-pr-55/shellcheck-result.xml

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/daapd/28.2-pkg-003c8411-pr-55/index.html https://ci-tests.linuxserver.io/lspipepr/daapd/28.2-pkg-003c8411-pr-55/shellcheck-result.xml

github-actions[bot] commented 2 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-2cef685a-pr-55/index.html https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-2cef685a-pr-55/shellcheck-result.xml

BernsteinA commented 2 years ago

I think we can merge this, but instead of removing a line from the changelog, let's add another to reflect that a change was made and then reverted

github-actions[bot] commented 2 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

linuxserver / docker-daapd