linuxserver / docker-daapd

GNU General Public License v3.0
103 stars 37 forks source link

Rebase to Alpine 3.15 #59

Closed thespad closed 2 years ago

thespad commented 2 years ago

linuxserver.io



Description:

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

thespad commented 2 years ago

@BernsteinA would you be able to test this PR? I've done a basic smoke test but that's all. Alpine 3.12 is EOL in March so we need to bump it to as recent an Alpine version as we can.

I have two questions:

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-71a7cab4-pr-59/index.html https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-71a7cab4-pr-59/shellcheck-result.xml

BernsteinA commented 2 years ago

@TheSpad sorry for the delay -- I'll check it out this weekend. I think yes we can remove libspotify, if spotify is already broken for ARM then that won't change anything unexpectedly for users who docker pull, right? I don't know about antlr, though.

thespad commented 2 years ago

@TheSpad sorry for the delay -- I'll check it out this weekend. I think yes we can remove libspotify, if spotify is already broken for ARM then that won't change anything unexpectedly for users who docker pull, right? I don't know about antlr, though.

OK well I'll push an update without libspotify and with libantlr3c to this PR and see if it works, if not I can roll back

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-493cce94-pr-59/index.html https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-493cce94-pr-59/shellcheck-result.xml

thespad commented 2 years ago

OK, give that a go and see if it's working as expected. If not I'll roll back the antl3r changes.

BernsteinA commented 2 years ago

@TheSpad crashing for me on aarch64 image: lspipepr/daapd:28.3-pkg-493cce94-pr-59

   ALSA lib confmisc.c:165:(snd_config_get_card) Cannot get card index for 0                                                                                                                  │
│   Failed to set ownership on logfile: Operation not permitted 
thespad commented 2 years ago

@TheSpad crashing for me on aarch64 image: lspipepr/daapd:28.3-pkg-493cce94-pr-59

   ALSA lib confmisc.c:165:(snd_config_get_card) Cannot get card index for 0                                                                                                                  │
│   Failed to set ownership on logfile: Operation not permitted 

Just aarch64 or is that all you've tested on?

BernsteinA commented 2 years ago

Just aarch64 or is that all you've tested on?

that's all I've tested on

thespad commented 2 years ago

Weird, it looks like it wants the logfile to be owned by the root GID but it's fine with the abc user owning it. See if this fixes the issue and if it breaks anything else.

thespad commented 2 years ago

Even weirder it's throwing that same error on the existing 3.12 build but not crashing

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-493cce94-pr-59/index.html https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-493cce94-pr-59/shellcheck-result.xml

BernsteinA commented 2 years ago

still crashing for me. getting this error but not sure if relevant ALSA lib confmisc.c:165:(snd_config_get_card) Cannot get card index for 0

thespad commented 2 years ago

Yeah I'm getting that too. Where's it getting to before crashing? Mine runs through to here and seems to be stable at that point

[2022-02-25 22:36:08] [  LOG]     mdns: Avahi state change: Client registering
[2022-02-25 22:36:08] [  LOG]       db: Configured to use database file '/config/dbase_and_logs/songs3.db'
[2022-02-25 22:36:08] [  LOG]       db: Now vacuuming database, this may take some time...
[2022-02-25 22:36:08] [  LOG]       db: Database OK with 0 active files and 6 active playlists
ALSA lib confmisc.c:165:(snd_config_get_card) Cannot get card index for 0
[2022-02-25 22:36:08] [  LOG]     scan: Bulk library scan completed in 0 sec
[2022-02-25 22:36:08] [  LOG]  spotify: No spotify refresh token found
[2022-02-25 22:36:08] [  LOG]  spotify: Spotify webapi token refresh failed. In order to use Spotify, authorize the server to access your saved tracks by visiting http://owntone.local:3689
[2022-02-25 22:36:08] [  LOG]      lib: Library init scan completed in 0 sec (0 changes)
Server startup complete. Host name is docker2.local. Local service cookie is 2386828788.
[2022-02-25 22:36:09] [  LOG]     mdns: Avahi state change: Client running
Service "docker2" (/etc/avahi/services/ssh.service) successfully established.
Service "docker2" (/etc/avahi/services/sftp-ssh.service) successfully established.
BernsteinA commented 2 years ago

@TheSpad are you using network_mode: host ? as soon as I connect via itunes it crashes

thespad commented 2 years ago

Yes, running in host but I don't have the ability to actually test anything in anger, no iTunes account or anything.

Let me roll back to a "vanilla" rebase without touching libspotify or antl3r and see how that looks.

thespad commented 2 years ago

@BernsteinA once that builds see if you're still getting the same crash issues.

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-493cce94-pr-59/index.html https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-493cce94-pr-59/shellcheck-result.xml

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-493cce94-pr-59/index.html https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-493cce94-pr-59/shellcheck-result.xml

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-493cce94-pr-59/index.html https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-493cce94-pr-59/shellcheck-result.xml

Hackashaq666 commented 2 years ago

Quick note, after updating to ls69 release, I cannot connect to the owntone server. I rolled back to ls68 and all is working well. Not sure if the rebase to 3.15 is working.

BernsteinA commented 2 years ago

@Hackashaq666 do you mind opening a new Issue? I'll admit we haven't got a great system for testing these updates

Hackashaq666 commented 2 years ago

I started from scratch with a fresh the ls69 container, re-paired with remotes and apple tv and it seems to be working. Will open a new issue if problems arise.

Thank you!