Make sure the user has access to the audio device

linuxserver / docker-daapd

GNU General Public License v3.0

103 stars 37 forks source link

Make sure the user has access to the audio device #62

Closed VergilGao closed 2 years ago

VergilGao commented 2 years ago

[x] I have read the contributing guideline and understand that I have made the correct modifications

Description:

fix https://github.com/linuxserver/docker-daapd/issues/40

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-eaff2da9-pr-62/index.html https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-eaff2da9-pr-62/shellcheck-result.xml

BernsteinA commented 2 years ago

seems fine to me

VergilGao commented 2 years ago

something goes wrong the group id of audio in container is 18, but to host it is 17 let me see how to handle this case

VergilGao commented 2 years ago

im sorry for that. add user who running the server into the audio group will fix the issue, but because of the different between host and container, i have no idea to solve this issue with this docker build. so i close this pr and try to build another docker image in my way. if i fixed this issue, i will open another pr :)

aptalca commented 2 years ago

It would have to be fixed like this: https://github.com/linuxserver/docker-plex/blob/master/root/etc/cont-init.d/50-gid-video

aptalca commented 2 years ago

You can use the same code, but just change the FILES var at the top: https://github.com/linuxserver/docker-plex/blob/master/root/etc/cont-init.d/50-gid-video#L3

VergilGao commented 2 years ago

thank you!