linuxserver / docker-daapd

GNU General Public License v3.0
103 stars 37 forks source link

Make sure the user has access to the audio device #64

Closed VergilGao closed 2 years ago

VergilGao commented 2 years ago

linuxserver.io



Description:

fix https://github.com/linuxserver/docker-daapd/issues/40

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-f53b033d-pr-64/index.html https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-f53b033d-pr-64/shellcheck-result.xml

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-f53b033d-pr-64/index.html https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-f53b033d-pr-64/shellcheck-result.xml

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-f53b033d-pr-64/index.html https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-f53b033d-pr-64/shellcheck-result.xml

VergilGao commented 2 years ago

anything goes wrong because of my force push?

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-f53b033d-pr-64/index.html https://ci-tests.linuxserver.io/lspipepr/daapd/28.3-pkg-f53b033d-pr-64/shellcheck-result.xml

VergilGao commented 2 years ago

Do I need to do anything else?

aptalca commented 2 years ago

@VergilGao Thanks for the PR. I was about to merge it, but realized daapd builds broke with the new version due to new deps needed. See here: #65 When that builds, can you give it a quick test as I'm not sure if those deps are needed runtime as well.

Thanks

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/daapd/28.4-pkg-fc2ad03f-pr-64/index.html https://ci-tests.linuxserver.io/lspipepr/daapd/28.4-pkg-fc2ad03f-pr-64/shellcheck-result.xml

VergilGao commented 2 years ago

@aptalca sorry for late reply im busy on my job this week, if i finish them, i will see what happens on the new version of daapd