linuxserver / docker-daapd

GNU General Public License v3.0
107 stars 36 forks source link

[FEAT] Will you be open to adding support for PulseAudio? #70

Closed MickMorley closed 1 year ago

MickMorley commented 1 year ago

Is this a new feature request?

Wanted change

Adding the --with-pulseaudio config is required when installing OwnTone. I have tested this by modifying your Dockerfile and installing it on my Unraid server.

Let me know if you are OK with it and I will make a pull request or someone can simple add pulseaudio-dev package to your both your build stage and runtime stage. And add --with-pulseaudio \ to the ./configure command.

Reason for change

I use a networked PulseAudio server to output audio to multiple zones in a HomeAudio setup. The PulseAudio plugin works amazing on OwnTone.

Proposed code change

github-actions[bot] commented 1 year ago

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

aptalca commented 1 year ago

Sure, feel free to open a PR. Are you sure the dev package is required runtime?

MickMorley commented 1 year ago

Thank you @aptalca, I will run a few more local dockerfile installs on my Unraid server and confirm if its needed at runtime.

MickMorley commented 1 year ago

Hi @aptalca I ran some tests and it does look like the dev package is required at runtime.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 1 year ago

This issue is locked due to inactivity