search

linuxserver / docker-ddclient

GNU General Public License v3.0
139 stars 36 forks source link

file permission on ddclient.conf #26

Closed davxiao closed 4 years ago

davxiao commented 4 years ago

linuxserver.io

If you are new to Docker or this application our issue tracker is ONLY used for reporting bugs or requesting features. Please use our discord server for general support.

ddclient.conf has permissions "-rwxrw-r-x " and after I changed it to 600, it was again overwritten by ddclient when container is restored

Expected Behavior

Current Behavior

Steps to Reproduce

1. 2. 3. 4.

Environment

OS: alpine linux CPU architecture: x86_64/arm32/arm64
How docker service was installed:

Command used to create docker container (run/create/compose/screenshot)

Docker logs

CHBMB commented 4 years ago

I can reproduce this. Looks like we chmod during init the ddclient.conf to 600, then subsequently recursively chmod /config subsequently.

https://github.com/linuxserver/docker-ddclient/blob/master/root/etc/cont-init.d/30-config#L18-L25

CHBMB commented 4 years ago

@davxiao Can you pull this image lspipepr/ddclient:3.9.0-pkg-7db5d2ed-pr-28 That is the image for the PR above.

If you can confirm that it

  1. Fixes the issue you're seeing
  2. Doesn't throw any errors

Then we should be good.