Add warning about the fact that the default config is overwritten

linuxserver / docker-ddclient

GNU General Public License v3.0

139 stars 36 forks source link

Add warning about the fact that the default config is overwritten #52

Closed rugk closed 1 year ago

rugk commented 3 years ago

[x] I have read the contributing guideline and understand that I have made the correct modifications

Description:

This Readme change aims to fix the problem described below by explicitly hinting at that file and shortly describing what happens, if you do not use/include the daemon=300 directive there.

Benefits of this PR and context:

I had the issue that if you include a config file the daemon=300 directive from the default ddclient config is not applied and you need it in your manual configuration file. Otherwise, ddclient pings the server way too fast, whcih can lead to rate limits etc.

How Has This Been Tested?

Locally by adjusting the config file.

Source / References:

https://talk.desec.io/t/running-into-429-too-many-requests-for-https-checkipv4-dedyn-io/284?u=rugk

LinuxServer-CI commented 3 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/ddclient/v3.9.1-pkg-89af875f-pr-52/index.html https://ci-tests.linuxserver.io/lspipepr/ddclient/v3.9.1-pkg-89af875f-pr-52/shellcheck-result.xml

github-actions[bot] commented 3 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

rugk commented 3 years ago

…

Roxedus commented 3 years ago

I don't think the term template really fits here, as it is a default file, that path is also not meant to be touched by the user. /config/ddclient.conf is the file the user is supposed to alter.

github-actions[bot] commented 3 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/ddclient/v3.9.1-pkg-fba6e7d8-pr-52/index.html https://ci-tests.linuxserver.io/lspipepr/ddclient/v3.9.1-pkg-fba6e7d8-pr-52/shellcheck-result.xml

github-actions[bot] commented 1 year ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 1 year ago

This pull request is locked due to inactivity