linuxserver / docker-ddclient

GNU General Public License v3.0
139 stars 36 forks source link

Healthcheck for ddclient #61

Closed SchoolGuy closed 2 years ago

SchoolGuy commented 2 years ago

linuxserver.io


Desired Behavior

It would be helpful to have a health-check available for the image to be able to tell if the container is responsive.

Current Behavior

Currently the fact that the container is running is indicating that ddclient is working, this is however an assumption that is not true in all cases.

Alternatives Considered

None

Context

github-actions[bot] commented 2 years ago

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

Roxedus commented 2 years ago

We are currently not interested in implementing healtchecks because of:

SchoolGuy commented 2 years ago

To be honest I find that having a health-check on all images as a very reasonable thing. It is informational but it is important information. The situation i described can happen to any daemon. In case the environment has little resources left it may be that such a situation is occurring and thus a container restart would help in solving such an unresponsive container. With a health-check this can be done automatically.

aptalca commented 2 years ago

You can add your own healthcheck runtime

https://docs.docker.com/compose/compose-file/compose-file-v3/#healthcheck

SchoolGuy commented 2 years ago

@aptalca I am very well aware. Since I am in a k8s env, I would do this anyway. I just wanted to raise this feature as it is beneficial for everyone imho.