linuxserver / docker-ddclient

GNU General Public License v3.0
139 stars 36 forks source link

Readme: Update docs with secret passing mechanism #76

Closed LenardHess closed 8 months ago

LenardHess commented 1 year ago

linuxserver.io



Remaining tasks

Description:

This PR adds documentation about the new secret passing mechanism of ddclient to the README. This feature is available as of prerelease v3.11.0_1 of ddclient.

Note: This is marked as draft, the relevant ddclient update has not reached this repo as only a prerelease was made. The relevant release should happen within a few days. (Relevant discussion here)

Benefits of this PR and context:

The need of a secret passing mechanism has been mentioned before (#44, #68). I'm guessing that the prior lack of it also led to attempts to bind-mount of the config file (#70).

How Has This Been Tested?

Local Jenkins run for README.md generation

Source / References:

The ddclient changelog here

The original ddclient pull request for the secret mechanism is here. This one was rejected due to the recent maintainership transition. It got picked up in the (now merged back) fork here.

I did not yet merge the docs update to ddclient.github.io, but the pull request is here.

LinuxServer-CI commented 1 year ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/ddclient/v3.10.0-pkg-c7503e33-dev-cc0d9d27e3a909a2b2d6c2948c52e147f085b05a-pr-76/index.html https://ci-tests.linuxserver.io/lspipepr/ddclient/v3.10.0-pkg-c7503e33-dev-cc0d9d27e3a909a2b2d6c2948c52e147f085b05a-pr-76/shellcheck-result.xml Tag Passed
amd64-v3.10.0-pkg-c7503e33-dev-cc0d9d27e3a909a2b2d6c2948c52e147f085b05a-pr-76
arm64v8-v3.10.0-pkg-c7503e33-dev-cc0d9d27e3a909a2b2d6c2948c52e147f085b05a-pr-76
LinuxServer-CI commented 1 year ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/ddclient/v3.11.0-pkg-3a436cd3-dev-1ac01ad14c132f82f92492cd07f7d1a145284c3d-pr-76/index.html https://ci-tests.linuxserver.io/lspipepr/ddclient/v3.11.0-pkg-3a436cd3-dev-1ac01ad14c132f82f92492cd07f7d1a145284c3d-pr-76/shellcheck-result.xml Tag Passed
amd64-v3.11.0-pkg-3a436cd3-dev-1ac01ad14c132f82f92492cd07f7d1a145284c3d-pr-76
arm64v8-v3.11.0-pkg-3a436cd3-dev-1ac01ad14c132f82f92492cd07f7d1a145284c3d-pr-76
LinuxServer-CI commented 11 months ago

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

LinuxServer-CI commented 11 months ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/ddclient/v3.11.2-pkg-03b434a4-dev-d1a871e391ce7d33655047c437ff192b5b78a19d-pr-76/index.html https://ci-tests.linuxserver.io/lspipepr/ddclient/v3.11.2-pkg-03b434a4-dev-d1a871e391ce7d33655047c437ff192b5b78a19d-pr-76/shellcheck-result.xml Tag Passed
amd64-v3.11.2-pkg-03b434a4-dev-d1a871e391ce7d33655047c437ff192b5b78a19d-pr-76
arm64v8-v3.11.2-pkg-03b434a4-dev-d1a871e391ce7d33655047c437ff192b5b78a19d-pr-76
drizuid commented 11 months ago

This is covered in the upstream documentation, our readme is not a reproduction of the app documentation. We clarify how our container might change locations or access requirements. As we do not change the behavior of this feature, I do not think it's appropriate to add to our readme.

LinuxServer-CI commented 10 months ago

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 7 months ago

This pull request is locked due to inactivity